Adjust to EnterNode change #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the EnterNode struct was added in JuliaLang/julia#52300 This commit adds support for ingesting and exporting CodeInfo with EnterNode but still uses `Expr(:enter)` inside IRTools IR. We may want to switch the representation to `IRTools.EnterNode` similarly to `IRTools.Slot` if more fields are added to the `Core.EnterNode` struct.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 73.43% 73.29% -0.15%
==========================================
Files 16 16
Lines 1487 1494 +7
==========================================
+ Hits 1092 1095 +3
- Misses 395 399 +4 ☔ View full report in Codecov by Sentry. |
In particular, JuliaLang/julia#51970 which adds more nodes in lowered ir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the EnterNode struct was added in JuliaLang/julia#52300 This commit adds support for ingesting and exporting CodeInfo with EnterNode but still uses
Expr(:enter)inside IRTools IR. We may want to switch the representation toIRTools.EnterNodesimilarly toIRTools.Slotif more fields are added to theCore.EnterNodestruct.This PR should probably not be merged before JuliaLang/julia#52309 which adds the scope field to
EnterNode.the broken test is fixed separately by #117.